Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on alpine-riscv64 #4787

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix build on alpine-riscv64 #4787

merged 2 commits into from
Jul 12, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 12, 2024 •
edited
Loading

cc @viewizard @gbalykov

docker run --rm -v$(pwd):/diagnostics -w /diagnostics --platform linux/riscv64 alpine:edge sh -c \
  'apk add build-base cmake bash curl clang llvm-dev lldb-dev   &&   ./build.sh -skipmanaged'

@am11 am11 requested a review from a team as a code owner July 12, 2024 20:23
@am11
Copy link
Member Author

am11 commented Jul 12, 2024

cc @shushanhf, LA64 can also use a port of libSOS to enable managed code debugging with lldb, see: https://github.com/dotnet/diagnostics/pulls?q=sort%3Aupdated-desc+is%3Apr+riscv64+is%3Aclosed.

viewizard
viewizard approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@viewizard viewizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbalykov
Copy link
Member

cc @dotnet/samsung

@mikem8361 mikem8361 merged commit 1fc8974 into dotnet:main Jul 12, 2024
17 of 20 checks passed
@am11 am11 deleted the feature/riscv-port branch July 13, 2024 00:53
@shushanhf
Copy link

cc @shushanhf, LA64 can also use a port of libSOS to enable managed code debugging with lldb, see: https://github.com/dotnet/diagnostics/pulls?q=sort%3Aupdated-desc+is%3Apr+riscv64+is%3Aclosed.

@am11 Thanks!
We are porting the related modules for LA64 and will push these.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gbalykov gbalykov gbalykov approved these changes

@viewizard viewizard viewizard approved these changes

@mikem8361 mikem8361 mikem8361 approved these changes

@clamp03 clamp03 clamp03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@am11 @gbalykov @shushanhf @clamp03 @mikem8361 @viewizard